Add node 21 to CI #2297
Open
Add node 21 to CI #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uneven node versions never become stable (lts). Are you sure you want to add it? |
|
@SleeplessByte Yes. I think we should keep the LTS (18) and latest (21) versions in CI. I guess many users installing nodejs first time might install the latest version. |
|
The latest version when uneven often just doesn't work for various reasons. I don't think we will be able to solve the issues that they run into. Can we mark the 21 one as "allowed to fail"? I do think we should add 20! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/en/blog/announcements/v21-release-announce