Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates Concept Exercise (Library Fees) #1787

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

JaPrad
Copy link
Contributor

@JaPrad JaPrad commented May 27, 2022

@junedev, I just wanted to ensure with you if the story in .docs/instructions.md file is okay. If it is, I will move forward writing the spec, test and other docs files

@github-actions
Copy link
Contributor

Dear JaPatGitHub

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 🧦 If you changed the function signature or the JSDoc comment in the exemplar file (.meta/exemplar.js) or the stub file (<exercise>.js), make sure the change is applied to both files.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@JaPrad JaPrad changed the title Dates Concept Exercise Dates Concept Exercise (Library Fees) May 27, 2022
@JaPrad
Copy link
Contributor Author

JaPrad commented Jun 9, 2022

@junedev , @SleeplessByte just a reminder

@junedev
Copy link
Member

junedev commented Jun 9, 2022

@JaPatGitHub Sorry for the delay, we were both busy. I have time again in the coming days. I will respond to your question as soon as possible.

@junedev
Copy link
Member

junedev commented Jun 29, 2022

@JaPatGitHub Great work on the story/tasks! With the last task I am not sure whether it will add anything really related to handling dates in the end. If not, maybe you can combine 4 and 5 into one task where the students needs to check for Monday and calculate the late fee so the story has a nice ending.

One more general comment regarding the instructions: After the header for an individual task and the story sentence, there should be a sentence that is very clear on what function to write and what inputs and outputs it has. See

Implement a function `totalBirdCount` that accepts an array that contains the bird count per day. It should return the total number of birds that you counted.
for an example of what I mean.
This is also described in the docs for concept exercises: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-instructions-md

@SleeplessByte
Copy link
Member

@JaPatGitHub Are you still working on this?

@JaPrad
Copy link
Contributor Author

JaPrad commented Aug 25, 2022

I'm sorry @SleeplessByte , I didn't notice @junedev 's reply in my last PR which I was waiting for. I'll start working on it right away.

@JaPrad
Copy link
Contributor Author

JaPrad commented Sep 11, 2022

@junedev , should I close this PR? Or do I just make the modifications you previously suggested so that who works next on this can use this story...

@SleeplessByte
Copy link
Member

@JaPatGitHub yes, let's not throwaway your hard work and author credit. If you could make those suggestions that'd be great. If not, that's also okay, then we stash it somewhere so the next person can continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants