Update to go version 1.21.1 #108
Conversation
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
I am preliminary re-opening the PR to see what CI has to say about this. Not sure whether there were changes to the test outputs again which would mean this is more work than changing a number. |
There was a problem hiding this comment.
@BramVanBerkel I noticed that if the docker container uses 1.21, we also need to use that for our tests. I pushed that change to your PR but as expected some tests are failing now, probably because the test output changed slightly. Can you have a look at fixing the tests so this can be merged?
|
I've fixed the tests, can the workflows be ran? 😄 |
In my exercises i came across a few instances where I was using go 1.21.1 locally, but the testrunner was running 1.20. This resulted in tests that passed locally, but not in the testrunner.
1.21 includes some new functions, most notably for me new functions for slices
We can also update the alpine image from 3.17 to 3.18 but was unsure if i also should include that in this PR, maybe that is better off in a new one.