New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 4 Support #110
Sphinx 4 Support #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 2 2
Lines 212 212
=======================================
Hits 206 206
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@foster999 could you take a look at the incompatibility with Sphinx 4? Feel free to push to my fork |
Thanks for this @Daltz333 I've compared outputs between sphinx 3.5.4 and 4 (pre-release). Looks like the formatting of to: This seems to be an intentional change to improve accessibility (sphinx-doc/sphinx#7849), so I'll push a new sphinx-version-dependent test for this. |
We may want to default html_codeblock_linenos_style to the old style for the user or expose with code-tab |
Good point! I've just tried setting the default to the old style in Looking at the sphinx changelog, they're depreciating the |
Yeah, didn't realize they are deprecating the "table" option. I would do a major version bump for it. |
I've pushed my changes, but I'm not sure how to conditionally skip the regression test |
Okay, got things figured out. Duplicated the We probably shouldn't merge this until Sphinx 4 gets a stable release, that way we don't need to pin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Agree that holding on for a more stable release might be best. Sounds like it might only be the end of the month
Co-authored-by: Pradyun Gedam <3275593+pradyunsg@users.noreply.github.com>
Release is only 5 days away. I'm going to go ahead and merge it, and we can test Sphinx 4 major/minor versions in a later PR. |
No description provided.