Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native JS clipboard interface #206

Closed
wants to merge 2 commits into from
Closed

Use native JS clipboard interface #206

wants to merge 2 commits into from

Conversation

nijel
Copy link

@nijel nijel commented Apr 14, 2023

Use navigator.clipboard.writeText instead of ClipboardJS.

First commit changes the implementation, second removes ClipboardJS.

Fixes #205
Fixes #97

@nijel
Use native JS clipboard interface
cfc9d91 
Use navigator.clipboard.writeText instead of ClipboardJS.
@welcome
Copy link

welcome bot commented Apr 14, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@nijel nijel mentioned this pull request Apr 14, 2023
Open
@nijel nijel marked this pull request as ready for review April 14, 2023 13:47
@nijel nijel mentioned this pull request Apr 14, 2023
Open
choldgraf
choldgraf approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I tried out several examples in our documentation and they all seemed to work as expected. I also too a look at the MDN docs on clipboard.writeText and it seems to have pretty good compatibility.

I'll leave this for a little bit just to see if anybody has an objection or a reason to hold off (@rkdarst @pradyunsg ?). I can't think of any myself, and think this is a nice simplification that should also reduce the payload and make it easier to maintain.

@nijel nijel closed this by deleting the head repository Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy button not shown on some pages Thoughts on dropping the dependency on clipboard.js?
2 participants
@nijel @choldgraf