Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on dropping the dependency on clipboard.js? #97

Open
pradyunsg opened this issue Sep 21, 2020 · 3 comments
Open

Thoughts on dropping the dependency on clipboard.js? #97

pradyunsg opened this issue Sep 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@pradyunsg
Copy link
Member

Is your feature request related to a problem? Please describe.

https://www.npmjs.com/package/clipboard-js -- clipboard.js is a deprecated package, and all the relevant APIs are available as vanilla JS in modern browsers.

Describe the solution you'd like

See https://tomspencer.dev/blog/2018/09/14/adding-click-to-copy-buttons-to-a-hugo-powered-blog/#final-code, which describes the entirety of what JS is needed to cleanly implement the same functionality on modern browsers.

Describe alternatives you've considered

Status quo? IDK any good alternatives to be honest.

Additional context

Nothing. I just realized that all Sphinx extensions that I generally recommend, are all now projects under the executablebooks umbrella. :)

@pradyunsg pradyunsg added the enhancement New feature or request label Sep 21, 2020
@welcome
Copy link

welcome bot commented Sep 21, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

I'm totally fine with it as long as the behavior stays the same. I used clipboard.js originally just because I'm not a JS developer and that was the fastest path towards getting a working functionality :-)

@nijel
Copy link

nijel commented Apr 14, 2023

#206 should address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants