Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also dispatch to custom component if node is an array. #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 1, 2023

I just came across that while re-reading the code. I think that's what we meant yesterday.

Also, that make me think that maybe we should revisit that, and have

if (!Array.isArray(ast)){
  ast = [ast]
}
/// unconditionally call the map code ?

That might avoid code duplication ?

@stevejpurves
Copy link
Member

@Carreau sorry we left this one hanging!
Is there a test case for this one - or from you comment, is this not the implementation we want?

@Carreau
Copy link
Contributor Author

Carreau commented Mar 7, 2024

Oh, I need to re-dive into this.

I think the patch we did before works only when you passed a single node, not when you pass a list of node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants