Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 RELEASE: v2.1.0 #213

Merged
merged 2 commits into from
Apr 16, 2022
Merged

馃殌 RELEASE: v2.1.0 #213

merged 2 commits into from
Apr 16, 2022

Conversation

chrisjsewell
Copy link
Member

@hukkin do you have any objections, regarding releasing this as 2.1 rather than 3.0?
Fo 99% of use cases, I don't think there should be a noticeable change, moving from attrs to dataclasses (it certainly did not affect myst-parser)

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #213 (1393760) into master (145a484) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          62       62           
  Lines        3221     3221           
=======================================
  Hits         3095     3095           
  Misses        126      126           
Flag Coverage 螖
pytests 96.08% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
markdown_it/__init__.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 145a484...1393760. Read the comment docs.

Copy link
Member

@hukkin hukkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object either version.

Personally I'd do 3.0 mainly because of Remove deprecated NestedTokens and nest_tokens. The deprecation is a nice warning, but if we strictly follow SemVer, I don't think it makes the removals any less breaking.

@hukkin
Copy link
Member

hukkin commented Apr 15, 2022

If you plan to merge #214 it may be a good idea to do so before the release. Merging it afterwards will introduce a breaking change, as __slots__ objects are stricter than objects without it (can't assign attributes dynamically).

@chrisjsewell chrisjsewell merged commit 7e677c4 into master Apr 16, 2022
@chrisjsewell chrisjsewell deleted the release-2-1 branch April 16, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants