🧑🏻🔬 Citations & bibliography #161
Conversation
|
|
| import { IRenderMimeRegistry } from '@jupyterlab/rendermime'; | ||
|
|
||
| import { notebookCellExecuted } from './actions'; | ||
| import { mystMarkdownRendererFactory } from './mime'; | ||
| import { citationRenderers } from './myst'; |
There was a problem hiding this comment.
@agoose77 we need some way to share the citation renderer into the various places we use those renderer. I don't think they necessarily need to be "connected" (i.e. an update to a bib file doesn't really need to force a re-render, but the next render should bring in the right citation).
The way we have done this in the CLI is to have a state manager, that is indexed based on file name, and then we combine citation renderers before we render the markdown.
I think this could work, and maybe that works? Curious if you know of a better way to share state between the plugins?
| if (renderer) { | ||
| citationRenderers[bibFile] = renderer; | ||
| } else { | ||
| delete citationRenderers[bibFile]; | ||
| } |
There was a problem hiding this comment.
When the manager changes, we just update the shared state, which is then available next time we render markdown. I don't really think we need to go full: update-the bib when the markdown changes as it could potentially render every single cell.
| }; | ||
| } | ||
|
|
||
| export function combineCitationRenderers(renderers: CitationRenderer[]) { |
There was a problem hiding this comment.
A bunch of this is copied from the CLI, we need to create a package, share this functionality and delete it here!
| activate: (app: JupyterFrontEnd) => { | ||
| console.log('Using jupyterlab-myst:bibliography'); | ||
|
|
||
| const bibFile = 'bibliography.bib'; |
There was a problem hiding this comment.
Right now this only works for a single bib file in the root.
rowanc1
force-pushed
the
agoose77/wip-bibliography
branch
from
105e29b
to
f9a0137
Compare
agoose77
force-pushed
the
agoose77/wip-bibliography
branch
from
f9a0137
to
19beaa3
Compare
Working on a first attempt to connect up citations.
Some things to think about for this PR:
bibliography.bib