馃殌 RELEASE: Setup and Changes for v0.12 #1494
Conversation
mmcky
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 7 7
Lines 680 680
=======================================
Hits 620 620
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mmcky
added
state: blocked
|
|
@choldgraf @chrisjsewell is there anything else we want to wrap into I have gone through the current open PR's and I think this looks like a good change to bundle in |
|
thanks for b5b66ba @choldgraf -- just getting back to this now. 鉂わ笍 |
|
@choldgraf so the |
|
I think it's a good idea 馃憤 |
|
Done - thanks @choldgraf for your review. Anything else? |
.github/workflows/tests.yml
Outdated
| - uses: actions/cache@v2 | ||
| with: | ||
| path: ~\AppData\Local\pip\Cache | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('setup.py') }} | ||
| key: ${{ runner.os }}-3.8-pip-${{ hashFiles('setup.py') }} |
There was a problem hiding this comment.
| key: ${{ runner.os }}-3.8-pip-${{ hashFiles('setup.py') }} | |
| key: ${{ runner.os }}-{{ python-version }}-pip-${{ hashFiles('setup.py') }} |
would something like this work? seems more DRY
There was a problem hiding this comment.
@choldgraf wasn't sure what to fetch python-version as a variable from. I am used to using matrix.python-version but not in this context. I have given that straight jinja substitution a go. The github action docs didn't seem to help me much either.
There was a problem hiding this comment.
@choldgraf yeah that didn't resolve the {{ python-version }}
There was a problem hiding this comment.
ah ok - I'm happy with whatever then, was just an idea :-)
nah the cache key has Been reading the docs -- I will just add a testing |
|
Ok everything is now resolving nicely in |
This PR updates version and CHANGELOG in preparation for
v0.12sphinx>=4,<5to run for all commitswin,osxtests to usepython=3.8frompython=3.7pypipublish workflow to usepython=3.8frompython=3.7branch protectionchecks to include3.8for Build Docs on OS Xfixes #1506 which resolves the current
cifailures on themasterbranch due to executablebooks/MyST-NB#365