Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Do not let sphinx check the config type #559

Merged
merged 1 commit into from Apr 20, 2022

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Apr 20, 2022

This is already validated by myst-parser

closes #558

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #559 (8909de2) into master (8854d84) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files          17       17           
  Lines        2154     2154           
=======================================
  Hits         1931     1931           
  Misses        223      223           
Flag Coverage Δ
pytests 89.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/__init__.py 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8854d84...8909de2. Read the comment docs.

@chrisjsewell chrisjsewell changed the title 👌 IMPROVE: Don't let sphinx check the config type 👌 IMPROVE: Do not let sphinx check the config type Apr 20, 2022
@chrisjsewell chrisjsewell merged commit 7dda7b5 into master Apr 20, 2022
@chrisjsewell chrisjsewell deleted the chrisjsewell-patch-2 branch April 20, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented breaking change between 0.17.2 from 0.17.0 — myst_url_schemes
1 participant