Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 TESTS: Fix test failure with Sphinx 4.5 #542

Merged
merged 5 commits into from Apr 13, 2022

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Apr 3, 2022

@welcome
Copy link

welcome bot commented Apr 3, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@57f7543). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #542   +/-   ##
=========================================
  Coverage          ?   89.78%           
=========================================
  Files             ?       16           
  Lines             ?     2104           
  Branches          ?        0           
=========================================
  Hits              ?     1889           
  Misses            ?      215           
  Partials          ?        0           
Flag Coverage Δ
pytests 89.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f7543...7f27a64. Read the comment docs.

@chrisjsewell chrisjsewell changed the title Fix test failure with Sphinx 4.5 🧪 TESTS: Fix test failure with Sphinx 4.5 Apr 13, 2022
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! (the python 3 issue I'll fix separately)

@chrisjsewell chrisjsewell merged commit c9c4f3b into executablebooks:master Apr 13, 2022
@welcome
Copy link

welcome bot commented Apr 13, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants