Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃И TESTS: Fix regression output on 32-bit systems to match 64-bit systems #523

Merged
merged 2 commits into from Apr 13, 2022
Merged

馃И TESTS: Fix regression output on 32-bit systems to match 64-bit systems #523

merged 2 commits into from Apr 13, 2022

Conversation

stefanor
Copy link
Contributor

Fixes test_sphinx_directives[35-highlight (sphinx.directives.code.Highlight):] which was failing on 32-bit platforms due to linenothreshold defaulting to sys.maxsize.

Fixes: #522

@stefanor
Massage test output on 32-bit systems to match 64-bit systems
84b0223 
Fixes test_sphinx_directives[35-highlight (sphinx.directives.code.Highlight):]
which was failing on 32-bit platforms due to linenothreshold defaulting
to sys.maxsize.

Fixes: executablebooks#522
@welcome
Copy link

welcome bot commented Feb 19, 2022

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@chrisjsewell chrisjsewell changed the title Massage test output on 32-bit systems to match 64-bit systems 馃И TESTS: Fix regression output on 32-bit systems to match 64-bit systems Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited

Codecov Report

Merging #523 (e59a911) into master (5cc398f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files          16       16           
  Lines        2104     2104           
=======================================
  Hits         1889     1889           
  Misses        215      215
Flag Coverage 螖
pytests 89.78% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5cc398f...e59a911. Read the comment docs.

chrisjsewell
chrisjsewell approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@chrisjsewell chrisjsewell merged commit 8f53a0b into executablebooks:master Apr 13, 2022
@welcome
Copy link

welcome bot commented Apr 13, 2022

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@stefanor stefanor deleted the 32bit branch April 14, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure on 32bit platforms: test_sphinx_directives[35-highlight (sphinx.directives.code.Highlight):]
2 participants
@stefanor @chrisjsewell