Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 FIX: parse_directive_text when body followed by options #520

Closed
wants to merge 1 commit into from

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 15, 2022

This was uncovered in executablebooks/markdown-it-docutils#28

The change does not break any existing tests, but I should add a test that would break without this change

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #520 (64eb0b6) into master (e477a75) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          16       16           
  Lines        2103     2103           
=======================================
  Hits         1894     1894           
  Misses        209      209           
Flag Coverage 螖
pytests 90.06% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
myst_parser/parse_directives.py 87.64% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e477a75...64eb0b6. Read the comment docs.

@rowanc1
Copy link
Member

rowanc1 commented Feb 15, 2022

So cool to see the JS implementation pushing on the python side. Love it. Thanks for making these changes here!

@chrisjsewell
Copy link
Member Author

superseded by #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants