Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Support include parser option in RST #419

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 22, 2021

supercedes #414

cc @cpitclaudel

closes #417
closes #388

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #419 (6a87085) into master (61f1154) will increase coverage by 0.09%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   90.67%   90.77%   +0.09%     
==========================================
  Files          14       16       +2     
  Lines        1855     1875      +20     
==========================================
+ Hits         1682     1702      +20     
  Misses        173      173              
Flag Coverage Δ
pytests 90.77% <96.42%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/sphinx_.py 0.00% <0.00%> (ø)
myst_parser/docutils_.py 100.00% <100.00%> (ø)
myst_parser/sphinx_parser.py 100.00% <100.00%> (+2.43%) ⬆️
myst_parser/sphinx_renderer.py 93.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f1154...6a87085. Read the comment docs.

@chrisjsewell
Copy link
Member Author

Note, this is not really the intended use case of myst_parser, so I won't be officially supporting it, i.e. if it does not work for whatever reasons, I won't treat that as a bug

@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: Support include parser option 🔧 MAINTAIN: Support include parser option in RST Aug 22, 2021
@chrisjsewell chrisjsewell merged commit be4838c into master Aug 22, 2021
@chrisjsewell chrisjsewell deleted the support-include branch August 22, 2021 07:50
@cpitclaudel
Copy link
Contributor

Thanks!

Question about your last comment: is building with Sphinx the only supported use case, or is the plan to also support building with the standard Docutils pipeline? (or in fact with other programs that build on top of it, like Pelican?)

The reason I'm asking is that I use the standard Docutils pipeline in plenty of places, and I wouldn't be against migrating these documents to Markdown — but I want to make sure that things aren't going to break unexpectedly.

@choldgraf
Copy link
Member

Cc @damianavila who was playing around with getting Myst to work in Nikola

@cpitclaudel
Copy link
Contributor

I think we would be super nice to be able to use MyST with docutils — the way reCommonMark can be used and through the usual methods in docutils.core. This parser is a great step in this direction, and I've opened a related feature request at #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants