Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump isort version #484

Closed
wants to merge 2 commits into from
Closed

fix: bump isort version #484

wants to merge 2 commits into from

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Apr 3, 2023

isort recently released a bugfix that fixes Poetry installation. We can upgrade our isort version to accommodate this.

@agoose77
Copy link
Collaborator Author

agoose77 commented Apr 3, 2023

@chrisjsewell I'd prefer to merge this following your review. Let me know if you're not going to be able to get to it — my judgement here is that this is a non-invasive, well motivated bugfix that only affects our dev environment, so I'm happy to merge it if you don't have availability. Just let me know!

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (385c4a7) 81.67% compared to head (a2ef997) 81.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   81.67%   81.63%   -0.04%     
==========================================
  Files          29       29              
  Lines        2647     2647              
==========================================
- Hits         2162     2161       -1     
- Misses        485      486       +1     
Flag Coverage Δ
pytests 81.63% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@choldgraf
Copy link
Member

@agoose77 ah this one got superceded by merging #460 - sorry for the confusion. Generally speaking you should feel free to self-merge clear fixes / maintenance improvements like this as long as they aren't too complex.

@choldgraf choldgraf closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants