Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace open4 library by open3 #825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace open4 library by open3 #825

wants to merge 2 commits into from

Commits on Jul 10, 2023

  1. Replace open4 library by open3 

    for the following reasons:

1. `open4` is 3rd party library while `open3` is part of StdLib.
2. It is not clear if `popen` is maintained upstream or if it is just
   stable.
3. There needis to be special handling for `IO.popen4` in JRuby while
   `Open3.popen3` should work the same everywhere.
    @voxik
    voxik committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b0663f7 View commit details
    Browse the repository at this point in the history

  2. Add JRuby into test matrix. 

    It was previously dropped by 27d23c4 for too many failures.
    @voxik
    voxik committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    91af4ab View commit details
    Browse the repository at this point in the history