Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise EOFError in Socket#readline instead of TypeError #740

Merged
merged 1 commit into from Mar 21, 2021
Merged

Raise EOFError in Socket#readline instead of TypeError #740

merged 1 commit into from Mar 21, 2021

Commits on Mar 20, 2021

  1. Raise EOFError in Socket#readline instead of TypeError 

    Before this patch the following error would be raised which could be
confusing:

Excon::Error::Socket: no implicit conversion of nil into String (TypeError)

Due to: `"" < nil`
    @carlhoerberg
    carlhoerberg committed Mar 20, 2021
    Copy the full SHA
    9ceaa9f View commit details
    Browse the repository at this point in the history