Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excon::Socket.readline to use buffered reads #720

Merged
merged 1 commit into from Jun 23, 2020
Merged

Excon::Socket.readline to use buffered reads #720

merged 1 commit into from Jun 23, 2020

Commits on Jun 18, 2020

  1. Excon::Socket.readline to use buffered reads 

    `Excon::Socket.readline` currently reads 1 byte at a time,
by performing one syscall for each byte (through `::Socket::read_nonblock`).
This change proposes to use the private `Excon::Socket.read_nonblock` primitive
instead, to benefit from the read buffer.

Tests & specs seem to run fine with this change.
    @kryzthov-stripe
    kryzthov-stripe committed Jun 18, 2020
    Copy the full SHA
    251488a View commit details
    Browse the repository at this point in the history