Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed response from proxy in ProxyConnectionError #715

Merged
merged 2 commits into from Mar 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/excon/error.rb
Expand Up @@ -50,7 +50,17 @@ class InvalidHeaderKey < Error; end
class InvalidHeaderValue < Error; end
class Timeout < Error; end
class ResponseParse < Error; end
class ProxyConnectionError < Error; end

class ProxyConnectionError < Error
cds2-stripe marked this conversation as resolved.
Show resolved Hide resolved
attr_reader :request, :response

def initialize(msg, request = nil, response = nil)
super(msg)
@request = request
@response = response
end
end

class ProxyParse < Error; end
class TooManyRedirects < Error; end

Expand Down
2 changes: 1 addition & 1 deletion lib/excon/ssl_socket.rb
Expand Up @@ -109,7 +109,7 @@ def initialize(data = {})
# eat the proxy's connection response
response = Excon::Response.parse(self, :expects => 200, :method => 'CONNECT')
if response[:response][:status] != 200
raise(Excon::Errors::ProxyConnectionError.new("proxy connection is not exstablished"))
raise(Excon::Errors::ProxyConnectionError.new("proxy connection could not be established", request, response))
end
end

Expand Down