New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use String#dup in Excon::Utils#binary_encode for frozen string #711
Conversation
5b4b44e
to
e7b75bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the detailed report and fix. I just have one area I'd like to discuss, which I'll comment on directly. Thanks!
Excon::Utils#binary_encode may receive frosen string.
e7b75bc
to
6609703
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again for the detailed report, fix, and quick update.
@unasuke do you need a release with these changes? |
@geemus Yes! I want a new release! 😆 |
No worries, if you didn't care I would probably just wait, but it's pretty easy to do. Released in v0.71.1. Thanks again! |
Thank you too! |
Hi, I'm Itamae gem maintainer.
https://github.com/itamae-kitchen/itamae
probrem
I found itamae gem's CI failing on ruby-head (it will release as Ruby 2.7).
I investigated about that reason.
CI failing by excon called from docker-api gem.
https://travis-ci.org/itamae-kitchen/itamae/builds/625473573
solution
Therefore, use
String#dup
inExcon::Utils#binary_encode
for frozen string literal, and caller assign returned duplicated string to a variable.https://travis-ci.org/itamae-kitchen/itamae/builds/626589627