Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate omit_default_port option, add include_default_port option #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate omit_default_port option, add include_default_port option #448

wants to merge 1 commit into from

Commits on Dec 5, 2014

  1. Deprecate omit_default_port option, add include_default_port option 

    - Port being added to URL can be forced by using include_default_port option
- Simplifies some of the port addition code
- Break out logic to determine if a default port is logic into its own method
- Tests basic cases of scheme+port combinations
    @mathias
    mathias committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    9d6e061 View commit details
    Browse the repository at this point in the history