Skip to content

Commit

Permalink
Support ActiveSupport v7
Browse files Browse the repository at this point in the history
https://github.com/excon/excon/runs/4781841441 was failing:

```
 Excon instrumentation
    basic notification - returns ["excon.request", "excon.response"]
    uninitialized constant ActiveSupport::IsolatedExecutionState (NameError)
      /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:268:in `registry'
      /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:263:in `instrumenter'
      /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:206:in `instrument'
```

As rails/rails#43852 explains, we can just
`require active_support` and this will auto-load the correct constants.
  • Loading branch information
stanhu committed Jan 11, 2022
1 parent 0ac208d commit f8d957a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/middlewares/instrumentation_tests.rb
@@ -1,4 +1,4 @@
require 'active_support/notifications'
require 'active_support'
require 'securerandom'

class SimpleInstrumentor
Expand Down

0 comments on commit f8d957a

Please sign in to comment.