Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sdk v46 #786

Merged
merged 140 commits into from Sep 13, 2022
Merged

chore: sdk v46 #786

merged 140 commits into from Sep 13, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 17, 2022

Description

  • sdk v46
  • ibc-go v5-rc0

This PR updates EVMOS to cosmos-sdk v0.46.1, tendermint v0.34.21, and ibc-go v5.0.0-rc1

The changes are coupled together because ibc-go v4.0.0 is not compatible with cosmos-sdk v0.46.*

One way to reduce the number of files changed in this PR would be to make a PR containing only the path change from github.com/evmos/evmos/v8 to github.com/evmos/evmos/v9


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

@faddat
Copy link
Contributor Author

faddat commented Jul 18, 2022

<3

PS: I think that you can use the protobuf build stuff directly from the cosmos-sdk.

@faddat faddat changed the title sdk v46 chore: sdk v46 Jul 18, 2022
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@MyloCyrus MyloCyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evmos/third_party/proto/cosmos/bank/v1beta1/authz.proto
Hackathon entry

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

@fedekunze it is true, 46 frees us from the grpc replace statement.

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

I went through the different items here, and want to flag I am by no means certain about how I did the upgrade handler folder.

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

NB: I think the commit timeout config is correct, it is:

// initTendermintConfig helps to override default Tendermint Config values.
// return tmcfg.DefaultConfig if no custom configuration is required for the application.
func initTendermintConfig() *tmcfg.Config {
	cfg := tmcfg.DefaultConfig()
	cfg.Consensus.TimeoutCommit = time.Second
	// to put a higher strain on node memory, use these values:
	// cfg.P2P.MaxNumInboundPeers = 100
	// cfg.P2P.MaxNumOutboundPeers = 40

	return cfg
}

cmd/evmosd/root.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! see my last comment @faddat. Thanks!

@danburck
Copy link
Contributor

@nghuyenthevinh2000 thanks for addressing all the comments! Approved from my side, but lets have @facs95 also review this, as there is no rush to push this and it is dependent on the next Ethemerint release.

@danburck
Copy link
Contributor

danburck commented Sep 5, 2022

@faddat I think we have enough approvals now 💪

Can you resolve the conflicts? Then we can merge this and update main with the new ethermint version once that is released.

@danburck
Copy link
Contributor

danburck commented Sep 9, 2022

@GNaD13 The PR is still blocked by conflicts.. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants