New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sdk v46 #786
chore: sdk v46 #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
This reverts commit 344b7eb.
Fix sdk-46 evmos test
<3 PS: I think that you can use the protobuf build stuff directly from the cosmos-sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evmos/third_party/proto/cosmos/bank/v1beta1/authz.proto
Hackathon entry
Dang/fix sdk46 test
@fedekunze it is true, 46 frees us from the grpc replace statement. |
I went through the different items here, and want to flag I am by no means certain about how I did the upgrade handler folder. |
NB: I think the commit timeout config is correct, it is: // initTendermintConfig helps to override default Tendermint Config values.
// return tmcfg.DefaultConfig if no custom configuration is required for the application.
func initTendermintConfig() *tmcfg.Config {
cfg := tmcfg.DefaultConfig()
cfg.Consensus.TimeoutCommit = time.Second
// to put a higher strain on node memory, use these values:
// cfg.P2P.MaxNumInboundPeers = 100
// cfg.P2P.MaxNumOutboundPeers = 40
return cfg
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! see my last comment @faddat. Thanks!
@nghuyenthevinh2000 thanks for addressing all the comments! Approved from my side, but lets have @facs95 also review this, as there is no rush to push this and it is dependent on the next Ethemerint release. |
@faddat I think we have enough approvals now 💪 Can you resolve the conflicts? Then we can merge this and update |
@GNaD13 The PR is still blocked by conflicts.. Can you take a look? |
Description
This PR updates EVMOS to cosmos-sdk v0.46.1, tendermint v0.34.21, and ibc-go v5.0.0-rc1
The changes are coupled together because ibc-go v4.0.0 is not compatible with cosmos-sdk v0.46.*
One way to reduce the number of files changed in this PR would be to make a PR containing only the path change from github.com/evmos/evmos/v8 to github.com/evmos/evmos/v9
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...