Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Change the fallback priority mechanism to be based on gas price #1289

Merged
merged 5 commits into from Sep 2, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 24, 2022

Description

port the changes from here: cosmos/cosmos-sdk#12953

should have no effect on existing chains if London hardfork is enabled.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1289 (5237da9) into main (efc5a15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   55.15%   55.16%           
=======================================
  Files         105      105           
  Lines        9607     9608    +1     
=======================================
+ Hits         5299     5300    +1     
  Misses       4043     4043           
  Partials      265      265           
Impacted Files Coverage Δ
app/ante/fee_checker.go 96.77% <100.00%> (+0.03%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@facs95 facs95 enabled auto-merge (squash) September 1, 2022 21:17
@facs95 facs95 merged commit 1a5b64d into evmos:main Sep 2, 2022
@yihuang yihuang deleted the default-prio branch September 2, 2022 01:34
Copy link

@AlphaMale1st AlphaMale1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlphaMale1st
Copy link

What should I change the price to ?

@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants