This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 530
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add integration test for the rollback cmd (#1311)
* test the fixed rollback cmd - check the rollback cmd works in integration tests * Apply suggestions from code review * upstream merged * add changelog Co-authored-by: Freddy Caceres <facs95@gmail.com>
- Loading branch information
Showing
12 changed files
with
155 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { pkgs ? import ../../../nix { } }: | ||
| let ethermintd = (pkgs.callPackage ../../../. { }); | ||
| in | ||
| ethermintd.overrideAttrs (oldAttrs: { | ||
| patches = oldAttrs.patches or [ ] ++ [ | ||
| ./broken-ethermintd.patch | ||
| ]; | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/app/app.go b/app/app.go | ||
| index 158bf7a3..a3b5718c 100644 | ||
| --- a/app/app.go | ||
| +++ b/app/app.go | ||
| @@ -681,6 +681,10 @@ func (app *EthermintApp) BeginBlocker(ctx sdk.Context, req abci.RequestBeginBloc | ||
|
|
||
| // EndBlocker updates every end block | ||
| func (app *EthermintApp) EndBlocker(ctx sdk.Context, req abci.RequestEndBlock) abci.ResponseEndBlock { | ||
| + if ctx.BlockHeight()%10 == 0 { | ||
| + store := ctx.KVStore(app.keys["evm"]) | ||
| + store.Set([]byte("hello"), []byte("world")) | ||
| + } | ||
| return app.mm.EndBlock(ctx, req) | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| local config = import 'default.jsonnet'; | ||
|
|
||
| config { | ||
| 'ethermint_9000-1'+: { | ||
| validators: super.validators + [{ | ||
| name: 'fullnode', | ||
| }], | ||
| }, | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import configparser | ||
| import subprocess | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| from pystarport import ports | ||
| from pystarport.cluster import SUPERVISOR_CONFIG_FILE | ||
|
|
||
| from .network import setup_custom_ethermint | ||
| from .utils import supervisorctl, wait_for_block, wait_for_port | ||
|
|
||
|
|
||
| def update_node2_cmd(path, cmd, i): | ||
| ini_path = path / SUPERVISOR_CONFIG_FILE | ||
| ini = configparser.RawConfigParser() | ||
| ini.read(ini_path) | ||
| for section in ini.sections(): | ||
| if section == f"program:ethermint_9000-1-node{i}": | ||
| ini[section].update( | ||
| { | ||
| "command": f"{cmd} start --home %(here)s/node{i}", | ||
| "autorestart": "false", # don't restart when stopped | ||
| } | ||
| ) | ||
| with ini_path.open("w") as fp: | ||
| ini.write(fp) | ||
|
|
||
|
|
||
| def post_init(broken_binary): | ||
| def inner(path, base_port, config): | ||
| chain_id = "ethermint_9000-1" | ||
| update_node2_cmd(path / chain_id, broken_binary, 2) | ||
|
|
||
| return inner | ||
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def custom_ethermint(tmp_path_factory): | ||
| path = tmp_path_factory.mktemp("rollback") | ||
|
|
||
| cmd = [ | ||
| "nix-build", | ||
| "--no-out-link", | ||
| Path(__file__).parent / "configs/broken-ethermintd.nix", | ||
| ] | ||
| print(*cmd) | ||
| broken_binary = ( | ||
| Path(subprocess.check_output(cmd).strip().decode()) / "bin/ethermintd" | ||
| ) | ||
| print(broken_binary) | ||
|
|
||
| # init with genesis binary | ||
| yield from setup_custom_ethermint( | ||
| path, | ||
| 26300, | ||
| Path(__file__).parent / "configs/rollback-test.jsonnet", | ||
| post_init=post_init(broken_binary), | ||
| wait_port=False, | ||
| ) | ||
|
|
||
|
|
||
| def test_rollback(custom_ethermint): | ||
| """ | ||
| test using rollback command to fix app-hash mismatch situation. | ||
| - the broken node will sync up to block 10 then crash. | ||
| - use rollback command to rollback the db. | ||
| - switch to correct binary should make the node syncing again. | ||
| """ | ||
| wait_for_port(ports.rpc_port(custom_ethermint.base_port(2))) | ||
|
|
||
| print("wait for node2 to sync the first 10 blocks") | ||
| cli2 = custom_ethermint.cosmos_cli(2) | ||
| wait_for_block(cli2, 10) | ||
|
|
||
| print("wait for a few more blocks on the healthy nodes") | ||
| cli = custom_ethermint.cosmos_cli(0) | ||
| wait_for_block(cli, 13) | ||
|
|
||
| # (app hash mismatch happens after the 10th block, detected in the 11th block) | ||
| print("check node2 get stuck at block 10") | ||
| assert cli2.block_height() == 10 | ||
|
|
||
| print("stop node2") | ||
| supervisorctl( | ||
| custom_ethermint.base_dir / "../tasks.ini", "stop", "ethermint_9000-1-node2" | ||
| ) | ||
|
|
||
| print("do rollback on node2") | ||
| cli2.rollback() | ||
|
|
||
| print("switch to normal binary") | ||
| update_node2_cmd(custom_ethermint.base_dir, "ethermintd", 2) | ||
| supervisorctl(custom_ethermint.base_dir / "../tasks.ini", "update") | ||
| wait_for_port(ports.rpc_port(custom_ethermint.base_port(2))) | ||
|
|
||
| print("check node2 sync again") | ||
| cli2 = custom_ethermint.cosmos_cli(2) | ||
| wait_for_block(cli2, 15) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters