EVG-18584 Upgrade go to go1.19 #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndaniels
approved these changes
Feb 24, 2023
| @@ -203,7 +203,7 @@ coverageHtmlOutput := $(foreach target,$(packages),$(buildDir)/output.$(target). | |||
| $(buildDir)/.lintSetup:$(buildDir)/golangci-lint | |||
| @touch $@ | |||
| $(buildDir)/golangci-lint: | |||
| @curl --retry 10 --retry-max-time 120 -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(buildDir) v1.40.0 >/dev/null 2>&1 && touch $@ | |||
| @curl --retry 10 --retry-max-time 120 -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(buildDir) v1.51.2 >/dev/null 2>&1 && touch $@ | |||
There was a problem hiding this comment.
This alone makes me very happy.
|
Opened evergreen-ci/spruce#1702 to fix spruce's e2e test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-18584
Description
This will upgrade go to 1.19. Once BUILD-16720 puts 1.20 on the hosts it'll be a hop, skip, and a jump to upgrade to 1.20 (EVG-19048).
No major changes. Most of the changes are because:
unusedlinter, which we're already using anyway.goimportsedgoimports(and gofmt) was formatting a bunch of the//nolintdirectives to// nolint(as of go1.19) which the docs say one shouldn't do "because machine-readable comments should have no space by Go convention". It would annoynolintlintif we had it enabled. The suggested solution is to follow the correct format so the tools recognize it as a directive. Along the way I discovered//nolint:allisn't understood by theevg-linter (EVG-19049) but I was able to specify specifically//nolint:evg-lintTesting
Works in staging™️
Does this need documentation?
No