Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warns about using multiple readers #960

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

4383
Copy link
Member

@4383 4383 commented May 15, 2024

No description provided.

@4383 4383 requested a review from itamarst May 15, 2024 08:27
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56%. Comparing base (ed743d7) to head (0326f82).

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #960   +/-   ##
=====================================
- Coverage      56%    56%   -1%     
=====================================
  Files          89     89           
  Lines        9773   9773           
  Branches     1821   1821           
=====================================
- Hits         5486   5485    -1     
- Misses       3916   3917    +1     
  Partials      371    371           
Flag Coverage Δ
ipv6 23% <ø> (ø)
py310asyncio 52% <ø> (ø)
py310epolls 53% <ø> (+<1%) ⬆️
py310poll 53% <ø> (-1%) ⬇️
py310selects 53% <ø> (-1%) ⬇️
py311asyncio 52% <ø> (-1%) ⬇️
py311epolls 53% <ø> (+<1%) ⬆️
py312asyncio 50% <ø> (+<1%) ⬆️
py312epolls 51% <ø> (-1%) ⬇️
py37asyncio 50% <ø> (-1%) ⬇️
py37epolls 51% <ø> (-1%) ⬇️
py38asyncio 51% <ø> (ø)
py38epolls 53% <ø> (-1%) ⬇️
py38openssl 51% <ø> (-1%) ⬇️
py38poll 53% <ø> (-1%) ⬇️
py38selects 53% <ø> (-1%) ⬇️
py39asyncio 51% <ø> (+<1%) ⬆️
py39dnspython1 51% <ø> (-1%) ⬇️
py39epolls 53% <ø> (-1%) ⬇️
py39poll 53% <ø> (+<1%) ⬆️
py39selects 52% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4383 4383 force-pushed the multiple_reader branch 2 times, most recently from 9d5c104 to 4f2df86 Compare May 15, 2024 09:07

But if you really know what you are doing you can change the state
to ``False`` to stop the hub from protecting against this mistake.
resource sharing consider using ``eventlet.pools.Pool`` instead.o
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo at end of sentence.

@4383 4383 merged commit ec6c0ff into eventlet:master May 16, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants