Make the docs more user friendly #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4383
commented
Mar 28, 2024
| @@ -1,4 +1,7 @@ | |||
| # Asyncio compatibility in eventlet | |||
| .. _asyncio-compatibility: | |||
There was a problem hiding this comment.
IMO it is better to move this file in the doc source and at the rst format.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
=====================================
- Coverage 56% 56% -1%
=====================================
Files 89 89
Lines 9767 9767
Branches 1819 1819
=====================================
- Hits 5478 5475 -3
- Misses 3920 3921 +1
- Partials 369 371 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
itamarst
reviewed
Apr 1, 2024
| @@ -44,6 +44,14 @@ eventlet.hubs.poll module | |||
| :undoc-members: | |||
| :show-inheritance: | |||
|
|
|||
| eventlet.hubs.pyevent module | |||
There was a problem hiding this comment.
Did you mean to restore this?
There was a problem hiding this comment.
Oh good catch. I think I forgot to rebase my development branch... Will fix that
itamarst
approved these changes
Apr 1, 2024
Improve the general index by adding a contribution guide, changelog, etc. Refactor sections to host various topics and to generate a more sexy table of context which will be more user friendly. Refactor formatting heading levels. Make Asyncio warning message reusable and centralized. Give more visibility to the Asyncio topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the general index by adding a contribution guide, changelog, etc.
Refactor sections to host various topics and to generate a more sexy table of context which will be more user friendly.
Refactor formatting heading levels.
Make Asyncio warning message reusable and centralized.
Give more visibility to the Asyncio topic.