[DNM][deprecation] deprecate non asyncio hubs #945
Conversation
In accordance with our recent maintenance goals we sets [1][2] and in accordance with the recent addition of the asyncio hub [3], this patch proposes to deprecate all the other existing hubs, the non asyncio hubs, to encourage users to start their migration to asyncio. [1] eventlet#835 [2] eventlet#824 [3] eventlet#868
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
=====================================
Coverage 56% 56%
=====================================
Files 89 89
Lines 9766 9776 +10
Branches 1818 1818
=====================================
+ Hits 5475 5484 +9
- Misses 3920 3921 +1
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
My concern is whether we think the asyncio hub is actually in working condition, since we've just fixed a bunch of major bugs in it. |
|
I was thinking to propose to holds this PR. Maybe we can hold it until as long as the work on the devstack integration is not completed. https://review.opendev.org/c/openstack/devstack/+/914108 We'll see more clearly once this work is finished. |
4383
changed the title
|
Updated the title with "do not merge". |
In accordance with our recent maintenance goals we sets [1][2] and in accordance with the recent addition of the asyncio hub [3], this patch proposes to deprecate all the other existing hubs, the non asyncio hubs, to encourage users to start their migration to asyncio.
[1] #835
[2] #824
[3] #868