Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on macOS in CI, and some fixes to get it in reasonable state #934

Merged
merged 13 commits into from
Mar 13, 2024

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Mar 13, 2024

I filed #935 as eventual follow-up to get a few tests actually passing, but this PR is an improvement on the status quo, at least.

@itamarst itamarst linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56%. Comparing base (1f3db00) to head (415d2fe).

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #934   +/-   ##
=====================================
  Coverage      56%    56%           
=====================================
  Files          89     89           
  Lines        9748   9751    +3     
  Branches     1812   1812           
=====================================
+ Hits         5471   5476    +5     
  Misses       3905   3905           
+ Partials      372    370    -2     
Flag Coverage Δ
ipv6 23% <33%> (+<1%) ⬆️
py310asyncio 53% <100%> (+<1%) ⬆️
py310epolls 53% <33%> (-1%) ⬇️
py310poll 53% <33%> (-1%) ⬇️
py310selects 53% <33%> (-1%) ⬇️
py311asyncio 53% <100%> (+<1%) ⬆️
py311epolls 53% <33%> (-1%) ⬇️
py312asyncio 50% <100%> (+<1%) ⬆️
py312epolls 51% <33%> (+<1%) ⬆️
py37asyncio 50% <100%> (-1%) ⬇️
py37epolls 51% <33%> (-1%) ⬇️
py38asyncio 51% <100%> (-1%) ⬇️
py38epolls 53% <33%> (-1%) ⬇️
py38openssl 52% <33%> (-1%) ⬇️
py38poll 53% <33%> (-1%) ⬇️
py38selects 53% <33%> (+<1%) ⬆️
py39asyncio 51% <100%> (-1%) ⬇️
py39dnspython1 51% <33%> (-1%) ⬇️
py39epolls 53% <33%> (-1%) ⬇️
py39poll 53% <33%> (-1%) ⬇️
py39selects 53% <33%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst itamarst marked this pull request as ready for review March 13, 2024 14:46
@itamarst itamarst changed the title WIP: macOS CI runners Run tests on macOS in CI, and some fixes to get it in reasonable state Mar 13, 2024
@itamarst itamarst requested a review from 4383 March 13, 2024 14:47
@itamarst
Copy link
Contributor Author

This should probably be merged before #930

@4383 4383 merged commit 88fd0e2 into master Mar 13, 2024
33 checks passed
@4383 4383 deleted the 933-macos-ci-runner branch March 13, 2024 15:25
@4383 4383 mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS CI runner
3 participants