Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wsgi: ignore ssl.SSLZeroReturnError at request finish() #787

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

temoto
Copy link
Member

@temoto temoto commented Jan 22, 2023

I believe this is correct way to deal with zero-read error at request finish. But please correct if wrong @eventlet/developers . Maybe better option to log client shutdown events, but then they are often considered log noise.

fixes #739

fixes #739

plus small cleanup of redundant lines in wsgi_test
@temoto temoto requested a review from tipabu January 22, 2023 04:23
@temoto
Copy link
Member Author

temoto commented Jan 22, 2023

To test this patch:

  • pip install -U https://github.com/eventlet/eventlet/archive/739-ssl-eof.zip
  • run https server using eventlet.wsgi
  • trigger by closing client connections mid-protocol (as in not after successful response)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e06bff1) 53% compared to head (f493084) 53%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #787   +/-   ##
=====================================
  Coverage      53%    53%           
=====================================
  Files          88     88           
  Lines        9869   9871    +2     
  Branches     1848   1849    +1     
=====================================
+ Hits         5325   5327    +2     
  Misses       4156   4156           
  Partials      388    388           
Flag Coverage Δ
ipv6 22% <0%> (-1%) ⬇️
py310epolls 52% <0%> (+<1%) ⬆️
py310poll 52% <0%> (-1%) ⬇️
py310selects 52% <0%> (-1%) ⬇️
py311epolls 52% <0%> (-1%) ⬇️
py312epolls 50% <0%> (-1%) ⬇️
py37epolls 50% <0%> (+<1%) ⬆️
py38epolls 52% <50%> (-1%) ⬇️
py38openssl 50% <50%> (-1%) ⬇️
py38poll 52% <50%> (-1%) ⬇️
py38selects 51% <50%> (-1%) ⬇️
py39dnspython1 50% <50%> (-1%) ⬇️
py39epolls 52% <50%> (-1%) ⬇️
py39poll 52% <50%> (-1%) ⬇️
py39selects 51% <50%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_017_ssl_zeroreturnerror raises SSLEOFError on Python 3.10
2 participants