Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using super() to prevent recursion #750

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jagguli
Copy link

@jagguli jagguli commented Feb 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #750 (dafc68f) into master (1f1f1ce) will increase coverage by 9%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #750     +/-   ##
=======================================
+ Coverage      43%    53%     +9%     
=======================================
  Files          88     88             
  Lines       12342   9907   -2435     
  Branches     1803   1747     -56     
=======================================
- Hits         5421   5281    -140     
+ Misses       6516   4271   -2245     
+ Partials      405    355     -50     
Flag Coverage Δ
py27dnspython1 54% <0%> (-1%) ⬇️
py27epolls 57% <0%> (-1%) ⬇️
py27poll 57% <0%> (-1%) ⬇️
py27selects 56% <0%> (-1%) ⬇️
py35epolls 50% <0%> (-1%) ⬇️
py35poll 50% <0%> (-1%) ⬇️
py35selects 50% <0%> (-1%) ⬇️
py36epolls 50% <0%> (-1%) ⬇️
py36poll 50% <0%> (-1%) ⬇️
py36selects 50% <0%> (-1%) ⬇️
py38epolls ?
py38openssl ?
py38poll ?
py38selects ?
py39dnspython1 ?
py39epolls ?
py39poll ?
py39selects ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 67% <0%> (+16%) ⬆️
eventlet/green/OpenSSL/__init__.py 71% <0%> (-29%) ⬇️
eventlet/green/http/cookiejar.py 0% <0%> (-1%) ⬇️
eventlet/zipkin/api.py 0% <0%> (ø)
eventlet/zipkin/wsgi.py 0% <0%> (ø)
eventlet/hubs/pyevent.py 0% <0%> (ø)
eventlet/green/builtin.py 0% <0%> (ø)
eventlet/zipkin/client.py 0% <0%> (ø)
eventlet/green/asynchat.py 0% <0%> (ø)
eventlet/green/asyncore.py 0% <0%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1f1ce...dafc68f. Read the comment docs.

_original_wrap_socket.__globals__['SSLContext'] = tmp_sslcontext
_original_sslsocket._create.__globals__['SSLSocket'] = tmp_sslsocket
_original_wrap_socket.__globals__["SSLContext"] = tmp_sslcontext
_original_sslsocket.sslsocket_class._create.__globals__[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't shrink it

there's max-line-width = 123 in tox.ini

if you want to introduce black formatter it's very much welcome in separate patch, with 123 width

@itamarst
Copy link
Contributor

Can you explain the purpose of this PR? Thank you!

Copy link
Contributor

@itamarst itamarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain the motivation for this PR, it's unclear to me.

@jagguli jagguli marked this pull request as draft February 5, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants