Only wrap socket.timeout on Python < 3.10 #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On py310, socket.timeout is TimeoutError, which our is_timeout() helper func already knows is a timeout. Note that this doesn't get us to py310 support (not by a long shot), but it's a step along the way. Closes eventlet#687
|
Abandoning in favor of #715 -- may as well take more than one step at a time. 😃 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On py310, socket.timeout is TimeoutError, which our is_timeout() helper func already knows is a timeout.
Closes #687
Note that this doesn't get us to py310 support (not by a long shot), but it's a step along the way. In particular, you'll get
trying to call
six.get_function_code(_original_pyio.open)in eventlet/greenio/py3.pyThis seems to be because of the resolution to https://bugs.python.org/issue43680