Clean up some warnings in wsgi_test #558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running tests with pytest would catch DeprecationWarning: cgi.parse_qs is deprecated, use urllib.parse.parse_qs instead and DeprecationWarning: capitalize_response_headers is disabled... The latter one was actually part of what was being tested, so make assertions about the warning being properly raised.
temoto
approved these changes
Oct 21, 2020
jstasiak
approved these changes
Oct 21, 2020
|
@tipabu it doesn't pass |
temoto
requested changes
Oct 21, 2020
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=====================================
Coverage 53% 53%
=====================================
Files 88 88
Lines 9881 9881
Branches 1852 1852
=====================================
Hits 5335 5335
Misses 4156 4156
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running tests with pytest would catch
and
The latter one was actually part of what was being tested, so make assertions about the warning being properly raised.