Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix patch builtin not work in py3 #545

Merged
merged 3 commits into from Oct 22, 2020

Conversation

Hanaasagi
Copy link
Contributor

resolves #541

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #545 into master will decrease coverage by <1%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #545   +/-   ##
=====================================
- Coverage      46%    46%   -1%     
=====================================
  Files          81     81           
  Lines        7966   7970    +4     
  Branches     1362   1364    +2     
=====================================
+ Hits         3709   3710    +1     
- Misses       3998   4001    +3     
  Partials      259    259
Flag Coverage Δ
#ipv6 15% <0%> (-1%) ⬇️
#py27epolls 50% <0%> (-1%) ⬇️
#py27poll 49% <0%> (-1%) ⬇️
#py27selects 49% <0%> (-1%) ⬇️
#py34epolls 42% <0%> (-1%) ⬇️
#py34poll 42% <0%> (ø) ⬆️
#py34selects 42% <0%> (-1%) ⬇️
#py35epolls 42% <0%> (-1%) ⬇️
#py35poll 42% <0%> (-1%) ⬇️
#py35selects 42% <0%> (ø) ⬆️
#py36epolls 42% <0%> (ø) ⬆️
#py36poll 42% <0%> (-1%) ⬇️
#py36selects 42% <0%> (-1%) ⬇️
#py37epolls 42% <0%> (-1%) ⬇️
#py37poll 42% <0%> (-1%) ⬇️
#py37selects 42% <0%> (-1%) ⬇️
Impacted Files Coverage Δ
eventlet/green/builtin.py 0% <0%> (ø) ⬆️
eventlet/hubs/hub.py 89% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d613d...7aa673f. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #545 into master will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #545   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11839   11844    +5     
  Branches     1777    1779    +2     
======================================
- Hits         5281    5280    -1     
- Misses       6163    6168    +5     
- Partials      395     396    +1     
Flag Coverage Δ
#ipv6 16% <0%> (-1%) ⬇️
#py27epolls 56% <0%> (-1%) ⬇️
#py27poll 56% <0%> (-1%) ⬇️
#py27selects 55% <0%> (-1%) ⬇️
#py35epolls 49% <0%> (-1%) ⬇️
#py35poll 49% <0%> (-1%) ⬇️
#py35selects 49% <0%> (-1%) ⬇️
#py36epolls 49% <0%> (-1%) ⬇️
#py36poll 49% <0%> (-1%) ⬇️
#py36selects 49% <0%> (-1%) ⬇️
#py37epolls 49% <0%> (+<1%) ⬆️
#py37poll 49% <0%> (-1%) ⬇️
#py37selects 49% <0%> (-1%) ⬇️
#py38epolls 41% <0%> (-1%) ⬇️
#py38poll 41% <0%> (-1%) ⬇️
#py38selects 40% <0%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/builtin.py 0% <0%> (ø)
eventlet/wsgi.py 70% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1aa58...97751fc. Read the comment docs.

Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch needs a test

Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@temoto temoto merged commit 089a1a7 into eventlet:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monkey_patch(builtins=True) fails in Python 3
4 participants