Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for case where db_pool connections can be lost. #527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Oct 8, 2018

  1. Configuration menu
    Copy the full SHA
    cc1293e View commit details
    Browse the repository at this point in the history
  2. Fix for case where db_pool connections can be lost.

    The problem occurs if:
    (1) A greenthread was waiting for a connection from the pool
    (2) Another thread calls put() to return a connection to the pool,
        but it has expired, so the first thread will be cleared to
        create a new connection
    (3) The create() method raises an exception that doesn't inherit
        from Exception, such as eventlet.Timeout
    
    Note that eventlet.pools.Pool.get uses "except:" instead of
    "except: Exception" to make sure all exceptions from create() are
    accounted for, but eventlet.db_pool.get() incorrectly uses
    "except: Exception" in the case where a returned connection was
    found to be unusable.
    erickj00001 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    b069731 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    ea84ab6 View commit details
    Browse the repository at this point in the history