greenpool: Make sure that imap/starmap set the correct pool #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling a GreenPool.imap() followed by a GreenPool.waitall() does not in fact wait on the threads that were spawned, this is because we create a completely new GreanPool instance for the resulting GreenPile result. We really want to be spawning threads limited by the GreenPool instance we call the imap() on, so we should be using it for the resulting GreenPile.
|
Hmmm... the CI failures do not seem to be related to my change. |
|
Closed and re-oppened in order to re-kick travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a GreenPool.imap() followed by a GreenPool.waitall() does not in fact
wait on the threads that were spawned, this is because we create a
completely new GreanPool instance for the resulting GreenPile result.
We really want to be spawning threads limited by the GreenPool instance
we call the imap() on, so we should be using it for the resulting GreenPile.