add separate keepalive_timeout to wsgi server #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is a nice feature. Someone has to write unit test for it, though. And I can't schedule it until late August. |
|
That's fine. We use a private eventlet with all our patches applied, so we're not waiting on anything. |
|
This is great and would be extremely useful to have. Unfortunately it's been a very long time since this was opened. Is this only waiting on a rebase and a unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, connections are kept alive for socket_timeout seconds (or forever if socket_timeout is None). This patch adds a separate option which is useful if you want idle connections to be kept around for a long time, but still have a low socket_timeout.