Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide API to create a custom esbuild CLI with plugins #3539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Provide API to create a custom esbuild CLI with plugins #3539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72d413
added new runImpl that takes plugins
edewit Nov 10, 2023
4309b3e
Update pkg/cli/cli_impl.go
edewit Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ import (
// "esbuild" executable such as the lack of auxiliary flags (e.g. "--help" and
// "--version") but it is otherwise exactly the same code.
func Run(osArgs []string) int {
return runImpl(osArgs)
return runImpl(osArgs, []api.Plugin{})
}

// This function invokes the esbuild CLI. It takes an array of command-line
// arguments (excluding the executable argument itself) and returns an exit
// code. It also takes adds some plugins that need to be added to the run
func RunWithPlugins(osArgs []string, plugin []api.Plugin) int {
return runImpl(osArgs, plugin)
}

// This parses an array of strings into an options object suitable for passing
Expand Down
3 changes: 2 additions & 1 deletion pkg/cli/cli_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ func addAnalyzePlugin(buildOptions *api.BuildOptions, analyze analyzeMode, osArg
buildOptions.Metafile = true
}

func runImpl(osArgs []string) int {
func runImpl(osArgs []string, plugins []api.Plugin) int {
// Special-case running a server
for _, arg := range osArgs {
if arg == "--serve" ||
Expand Down Expand Up @@ -1278,6 +1278,7 @@ func runImpl(osArgs []string) int {
}
}

buildOptions.Plugins = plugins
// Handle post-build actions with a plugin so they also work in watch mode
buildOptions.Plugins = append(buildOptions.Plugins, api.Plugin{
Name: "PostBuildActions",
Expand Down