Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the module condition's purpose in the code comment #3138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify the module condition's purpose in the code comment #3138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/api/api_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,7 +1406,7 @@ func validateBuildOptions(
options.Mode = config.ModeConvertFormat
}

// Automatically enable the "module" condition for better tree shaking
// Automatically enable the "module" condition that allows package authors to avoid dual package hazard when their packages are bundled
if options.Conditions == nil && options.Platform != config.PlatformNeutral {
options.Conditions = []string{"module"}
}
Expand Down