Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover from panic when generating chunks #1808

Merged
merged 2 commits into from Nov 27, 2021
Merged

recover from panic when generating chunks #1808

merged 2 commits into from Nov 27, 2021

Conversation

sbfaulkner
Copy link
Contributor

further to #1803 this PR recovers from any panics in the goroutines, converting them to errors (which can then be handled appropriately)

eg.

$ bin/esbuild --loader=css --minify <bad.css
 > <stdin>:9:1: warning: Expected ";"
    9 │ }
      ╵  ^

 > error: Internal error: runtime error: index out of range [1] with length 1

1 warning and 1 error

@evanw evanw merged commit ca852d3 into evanw:master Nov 27, 2021
@sbfaulkner sbfaulkner deleted the chunk-recover branch November 29, 2021 13:58
@sbfaulkner
Copy link
Contributor Author

thanks @evanw - the changes you made on top of this make it even better 🥂

I'm not sure what your release cadence is, but I'd love to see a 0.14.1 when you get a chance ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants