Revert change to use get_script_prefix #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
script_prefix_setting
branch
from
369a97e
to
cc9015e
Compare
sarahboyce
force-pushed
the
script_prefix_setting
branch
from
cc9015e
to
b49a8a6
Compare
sarahboyce
force-pushed
the
script_prefix_setting
branch
from
484ceb8
to
f6e5621
Compare
|
@evansd @adamchainz I've now added a changelog, I think this is ready for a review 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢
This reverts this change #259 which added the use of
get_script_prefixin the middleware init.Unfortunately this function is not designed to be used outside the request response cycle and as middleware is initialised outside of that, this is causing unexpected results. For now reverting this change is the best solution to resolve this issue #271 馃憤
Note: You can see here a suggestion to have a better way to access this outside the request response cycle is being discussed