use runtime.Frame instead of program counters after braking change to github.com/pkg/errors #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com/pkg/errors See [Issue](evalphobia#74)
|
@evalphobia errr my CI fails due to some thing irrelevant to my change made. Apparently we had to skip one more level of stacktrace. I think it's related to this! Why everyone has to do breaking changes.. stop this already :'( |
…/logrus Apparently due to this [merge request](sirupsen/logrus#863) another level to stacktrace was introduced. So if we intend to skip it by default we have to increase default number of skips in our configuration.
|
I've added another commit :'( Since we have breaking change in 2 libraries I think we won't be able to make it through using 2 sperate PR's :'( |
|
Just as clarification.. apparently this: func (logger *Logger) Error(args ...interface{}) {
if logger.IsLevelEnabled(ErrorLevel) {
entry := logger.newEntry()
entry.Error(args...)
logger.releaseEntry(entry)
}
}was changes to this.. func (logger *Logger) Error(args ...interface{}) {
logger.Log(ErrorLevel, args...)
}which means we had to increase our |
|
Thank you! 🌱 Nite: https://github.com/evalphobia/logrus_sentry/releases/tag/v0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently today, authors of github.com/pkg/errors have decided to pull off a breaking change in which they replace using PC's as type
errors.Frameand useruntime.Frameas typeerrors.Frame. This PR fixes this issue by usingruntime.Frames instead of program counters.See Issue