Skip to content

Commit

Permalink
Commit to a MSRV of 1.34.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@eupn
eupn committed Dec 11, 2020
1 parent 059fb0c commit 7e76cf1
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Cargo.toml
View file
@@ -1,6 +1,6 @@
[package]
name = "macrotest"
version = "1.0.6" # remember to update in lib.rs
version = "1.0.7" # remember to update in lib.rs
authors = ["eupn <eupn@protonmail.com>"]
edition = "2018"
license = "MIT OR Apache-2.0"
Expand All @@ -14,4 +14,4 @@ glob = "0.3"
rand = "0.7.3"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
toml = "0.5"
toml = "0.4"

This comment has been minimized.

Sign in to view

Copy link
@taiki-e

taiki-e Dec 11, 2020

Collaborator

Why was toml dependency downgraded to an older version? (As far as I know, the latest version of toml (0.5.7) can be compiled on Rust 1.31+.)

This comment has been minimized.

Sign in to view

Copy link
@eupn

eupn Dec 11, 2020

Author Owner

As soon as I set the rust toolchain version to 1.34.0, I had a build error related to this crate and immediately decided to try a lower version which has fixed it. Now, after I cleaned everything up and rebuilt it from scratch, it seems to work with 0.5 too as you said. We could bump this version back if needed, but it seems to work.

This comment has been minimized.

Sign in to view

Copy link
@taiki-e

taiki-e Dec 11, 2020 •
edited

Collaborator

As soon as I set the rust toolchain version to 1.34.0, I had a build error related to this crate and immediately decided to try a lower version which has fixed it.

Ah, an older version of toml 0.5 certainly didn't seem to be compatible with Rust 1.34, so the build error is probably related to that.

We could bump this version back if needed, but it seems to work.

I recommend using the latest version (0.5) if possible, as older versions (0.4) are no longer maintained and will not be fixed even if there are serious bugs.

EDIT: filed #55

This comment has been minimized.

Sign in to view

Copy link
@eupn

eupn Dec 11, 2020

Author Owner

Noted, I will update the toml crate then.
3 changes: 3 additions & 0 deletions README.md
View file
Expand Up @@ -2,12 +2,15 @@

[![Travis-CI](https://api.travis-ci.com/eupn/macrotest.svg?branch=master)](https://travis-ci.com/eupn/macrotest)
[![Crates.io](https://img.shields.io/crates/v/macrotest)](https://crates.io/crates/macrotest)
![MSRV 1.34.0](https://img.shields.io/badge/MSRV-1.34.0-orange.svg)
[![docs.rs](https://docs.rs/macrotest/badge.svg)](https://docs.rs/macrotest/)
[![Crates.io](https://img.shields.io/crates/d/macrotest)](https://crates.io/crates/macrotest)
[![Crates.io](https://img.shields.io/crates/l/macrotest)](https://crates.io/crates/macrotest)

Similar to [trybuild], but allows you to test how declarative or procedural macros are expanded.

*Minimal Supported Rust Version: 1.34.0*

----

## Documentation
Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
View file
@@ -1,10 +1,12 @@
#![crate_type = "lib"]
#![doc(html_root_url = "https://docs.rs/macrotest/1.0.6")]
#![doc(html_root_url = "https://docs.rs/macrotest/1.0.7")]

//! #### &emsp; Test harness for macro expansion.
//!
//! Similar to [trybuild], but allows you to write tests on how macros are expanded.
//!
//! *Minimal Supported Rust Version: 1.34.0*
//!
//! <br>
//!
//! # Macro expansion tests
Expand Down
10 changes: 5 additions & 5 deletions test-project/Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7e76cf1

Please sign in to comment.