Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades #8

Merged
merged 6 commits into from Feb 10, 2021
Merged

Dependency upgrades #8

merged 6 commits into from Feb 10, 2021

Conversation

joebeachjoebeach
Copy link
Contributor

Read this commit by commit.

Upgrade info

Husky 4.2.5 -> 5.0.9

  • What's new in Husky 5
  • Release notes
  • v5 has a lot of changes. The whole interface is totally different. I have all the necessary changes grouped into a single commit, but they include:
    • Using pinst to ensure that hooks only get installed in dev, and not when kevin's being installed in someone else's project.
    • Moving hook definitions out of package.json and into individual files in the .husky/ directory. Husky places its own .gitignore in that directory, which ignores the results of the local hook installation.

Install pinst 2.1.4

I added this at the recommendation of the Husky docs. It allows us to add the hooks only in dev.

Jest 26.2.1 -> 26.6.3

  • Release notes
  • No significant changes, really. All of our tests still run and pass.
  • This issue blocked this upgrade internally at Etsy, but we don't use objectContaining in Kevin tests, so I think it's safe to ignore.

Prettier 1.19.1 -> 2.2.1

  • Changelog
  • Ultimately this only affects us in that prettier has some new rules/preferences.
  • I ran npx prettier --write on the whole codebase to bring us in alignment with the new conventions.

pretty-quick 2.0.1 -> 3.1.0

  • Release notes
  • The only breaking change is that Node >=10.13.0 is required. I think it's safe enough to require contributors to be using a more recent version of Node.

Copy link
Contributor

@salemhilal salemhilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am into it!

@joebeachjoebeach joebeachjoebeach merged commit 0ab9c83 into master Feb 10, 2021
@joebeachjoebeach joebeachjoebeach deleted the jbeach/updates branch February 10, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants