Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3551 clean up #524

Merged
merged 44 commits into from Oct 7, 2022
Merged

Feature/3551 clean up #524

merged 44 commits into from Oct 7, 2022

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Oct 6, 2022

Changes proposed in this Pull Request:

Overall
  • Add favicon
  • Remove the Home Screen & automatically redirect to the first component in the list (App Bar)
  • Persist Active Tab between page changes
  • Change Code block highlighting styles (normal and hrefs)
API Pages
  • Replace Channel Value component picture on README
  • Only show Drawer API docs (as opposed to Drawer, DrawerLayout, DrawerHeader, ...) while on the Drawer page.
  • Update all MD docs to add single-quotes are string types (e.g 'dots', 'text', etc)
Examples
  • Gracefully handle code block overflows on the examples page
  • Round the codeblock and example container corners (4px)
  • Fix content appearing underneath the Mat Tab Header when scrolling on Mobile Devices
Playground
  • Add a Drawer Nav Item under DrawerSubheader playground example
  • Fix DrawerSubheader divider description
  • Make long knob names on the playground wrap onto 2 lines (e.g. Drawer Playground disableActivePlaygroundStyles knob)
  • Add Left & Right content knobs for Info List Item playground
  • Change default Scorecard playground badge offset value
  • Update ThreeLiner playground generated code to handle empty strings for title, subtitle, info
  • Fix Color knob & Number knob not updating value (in input field) on change.

@emclaug2
Copy link
Contributor Author

emclaug2 commented Oct 6, 2022

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Visit the preview URL for this PR (updated for commit 0a800fc):

https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app

(expires Sun, 09 Oct 2022 16:08:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 464f9d32afc68faddbb7bee221e2b2da409ea721

@jeffvg
Copy link
Contributor

jeffvg commented Oct 6, 2022

did the color knob fix get checked in?
setting drawer header to warn is placed in code snippet but is not set
https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/drawer/header/playground

setting the info list item status color not updated in the input
https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/info-list-item/playground

list item tag color picker not set to defaults
https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/list-item-tag/playground

@jeffvg
Copy link
Contributor

jeffvg commented Oct 6, 2022

one typo didn't make it in for empty state example doc "Customing the Title and Description"
https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/empty-state/examples

@emclaug2
Copy link
Contributor Author

emclaug2 commented Oct 6, 2022

list item tag color picker not set to defaults https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/list-item-tag/playground

I've fixed the color input should it should now be responsive.
The ListItemTag doesn't really have component-level defaults; these values are provided by the theme so I've left the knobs (and input props) undefined by default.

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

the API table feels very condensed. The padding got overridden

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

scorecard playground, this line's indentation is missing one space

image

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

User menu API Doc, the Default value of this input is styled awkwardly

image

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

Channel Value, API Docs, this needs to be monospaced
image

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

"Spacer with Flex" story, consider setting the flex of the second rect to 2, and the third rect to 3, to be consistent with the numbers labeled inside the square (and match React)

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

(I really have not much to say here; I think the current ng dev doc looks fantastic and had to be extra picky to get those comments above)

@emclaug2
Copy link
Contributor Author

emclaug2 commented Oct 7, 2022

Thanks for the comments @huayunh & @jeffvg - all points should be addressed now 👍

@jeffvg
Copy link
Contributor

jeffvg commented Oct 7, 2022

did the color knob fix get checked in? setting drawer header to warn is placed in code snippet but is not set https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/drawer/header/playground

setting the info list item status color not updated in the input https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/info-list-item/playground

list item tag color picker not set to defaults https://blui-angular-docs--pr524-feature-3551-clean-u-q4yzcu0t.web.app/components/list-item-tag/playground

looks like this playground color needs updated from above comment....other than that this looks really awesome!

image

@emclaug2
Copy link
Contributor Author

emclaug2 commented Oct 7, 2022

looks like this playground color needs updated from above comment....other than that this looks really awesome!

image

This particular problem is at the component-level (possibly even the theme); we've logged an issue for this one a month ago:
https://github.com/brightlayer-ui/angular-component-library/issues/471

If preferred I can remove the knob until this issue is fixed.

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

one small thing: the site drawer's activeItemShape shall be round

@emclaug2
Copy link
Contributor Author

emclaug2 commented Oct 7, 2022

one small thing: the site drawer's activeItemShape shall be round

Updated 🚀

@huayunh
Copy link
Contributor

huayunh commented Oct 7, 2022

lets go

@huayunh huayunh merged commit db44ee2 into dev Oct 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/3551-clean-up branch October 7, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants