mirrorbits-del-stats: allow passing the host to redis-cli #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
added a commit
to msys2/msys2-main-server
that referenced
this pull request
Apr 27, 2024
It has no logic for separating forwarded and its own args, and it just stops at the first unknown option, so pass "-p" first so "-h" isn't interpreted as "--help" See etix/mirrorbits#177
Passing the host to redis-cli is only possible via the "-h" switch, which clashes with the "-h" interpreted as "--help" in the script. Make "--" stop the argument parsing, so "-h" can be forwarded to redis-cli: mirrorbits-del-stats daily:30 monthly:12 -- -h redis
lazka
force-pushed
the
del-stats-forward
branch
from
ae4cf9f
to
4b2d608
Compare
|
Looks good, thank you! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the host to redis-cli is only possible via the "-h" switch, which clashes with the "-h" interpreted as "--help" in the script.
Make "--" stop the argument parsing, so "-h" can be forwarded to redis-cli:
mirrorbits-del-stats daily:30 monthly:12 -- -h redis