Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CI #173

wants to merge 1 commit into from

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Apr 26, 2024

Test with some random golang versions which also happen
to exist in Debian releases

@lazka
Copy link
Contributor Author

lazka commented Apr 26, 2024

This branch is currently based on an older commit, since everything after that fails to build, see #172

It looks like Actions is disabled for this repo, @jbkempf could you enable it? (allowing GitHub-created actions should be enough, but whatever you prefer)

@lazka lazka marked this pull request as draft April 26, 2024 16:10
@lazka lazka marked this pull request as ready for review April 26, 2024 17:22
Test with some random golang versions which also happen
to exist in Debian releases
@lazka
Copy link
Contributor Author

lazka commented Apr 26, 2024

This is green now, here is how it looks like on my fork: https://github.com/lazka/mirrorbits/actions/runs/8852010335

jobs:
build:
name: Build and Test
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should fix that to a specific version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will do

run: |
make test

- name: Create release tarball
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make that only on tags?

Copy link
Contributor Author

@lazka lazka Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we test that creating a release works and continues to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants