Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility with python 2.7 #126

Closed
wants to merge 1 commit into from

Conversation

ryanbagwell
Copy link

@ryanbagwell ryanbagwell commented Jul 20, 2021

I recently had the need to switch from django-storages to django-s3-storage because of matthewwithanm/django-imagekit#391. This adds a bit of backwards compatibility with python 2.7.

Note - I just found the commit from 2019 that dropped support for Django < 2.2, which also dropped support for Python 2.7. Please consider this PR anyway as the changes are relatively minor.

@etianen
Copy link
Owner

etianen commented Jul 21, 2021

From the Django docs: The last version to support Python 2.7 is Django 1.11 LTS.

And Django 1.11 LTS has been out support for a while now. So AFAIK there's no supported version of Django that supports Python 2.7, which is itself unsupported from the core CPython team.

I see that your changes are relatively minor, but I'm afraid I don't really want to introduce any complexity to support software that's otherwise unsupported. At this point, using Python 2.7 and Django 1.11 is going to cause a whole lot of security problems and runtime issues. I realize that there can be some pragmatic reasons for using Python 2.7, and I certainly feel your pain!

I'd suggest maintaining your own fork of this project if you need Python 2.7 support. It's not a huge burden at this point, as the codebase is pretty stable.

@etianen etianen closed this Jul 21, 2021
@ryanbagwell
Copy link
Author

@etianen understood. No worries. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants